Merge pull request #3841 from thematters/fix/review-e2e-error

Fix/review e2e error
thematters · Oct 17, 2023 · 8550950 · 8550950 · vercel · Oct 17, 2023
2 parents 5683df3 + 43bc5d5
commit 8550950
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/tests/helpers/auth.ts b/tests/helpers/auth.ts
@@ -46,7 +46,7 @@ export const login = async ({
   }
 
   // Login with email & password
-  await page.getByRole('button', { name: 'Continue with Email' }).click()
+  await page.getByRole('button', { name: 'Email', exact: true }).click()
 
   // Fill the form
   await page.getByPlaceholder('Email').fill(email)
@@ -58,7 +58,7 @@ export const login = async ({
   await Promise.all([
     waitForAPIResponse({
       page,
-      path: 'data.userLogin.token',
+      path: 'data.emailLogin.token',
     }),
     waitForNavigation ? page.waitForNavigation() : undefined,
   ])

diff --git a/tests/helpers/poms/draftDetail.ts b/tests/helpers/poms/draftDetail.ts
@@ -3,6 +3,7 @@ import _sample from 'lodash/sample'
 import _uniq from 'lodash/uniq'
 
 import { PATHS, TEST_ID } from '~/common/enums'
+import { sleep } from '~/common/utils/time'
 
 import { waitForAPIResponse } from '../api'
 import {
@@ -95,8 +96,8 @@ export class DraftDetailPage {
     })
 
     // editing
-    this.titleInput = this.page.getByPlaceholder('Enter title')
-    this.summaryInput = this.page.getByPlaceholder('Enter summary')
+    this.titleInput = this.page.getByPlaceholder('Enter title ...')
+    this.summaryInput = this.page.getByPlaceholder('Enter summary…')
     this.contentInput = this.page.locator('.tiptap')
 
     // dialog
@@ -164,7 +165,16 @@ export class DraftDetailPage {
   async fillContent() {
     const content = generateContent({})
     await this.contentInput.fill(content)
-    return content
+
+    // Update the content to make the publish button clickable
+    await this.contentInput.press('KeyA')
+    await sleep(5 * 1000)
+    await this.contentInput.press('KeyB')
+    await this.contentInput.press('KeyC')
+    await this.contentInput.press('KeyD')
+    await sleep(5 * 1000)
+
+    return content + 'abcd'
   }
 
   async setTags() {

diff --git a/tests/mutateArticle.spec.ts b/tests/mutateArticle.spec.ts
@@ -255,6 +255,7 @@ test.describe('Mutate article', () => {
     // Goto republished article page
     await draftDetail.dialogViewRepublishedArticle.click()
     await alicePage.waitForLoadState('networkidle')
+    await sleep(3 * 1000)
     const articleContent = await aliceArticleDetail.content.innerText()
     expect(stripSpaces(articleContent)).toBe(stripSpaces(newContent))
   })