Merge branch 'develop' into prototype/new-top-nav

thematters · Dec 30, 2024 · 404e606 · 404e606
2 parents a18c5a9 + e52a80a
commit 404e606
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/common/utils/analytics.ts b/src/common/utils/analytics.ts
@@ -241,7 +241,7 @@ interface AuthenticateProp {
 }
 
 interface ReadTimeProp {
-  articleId: string
+  shortHash: string
   time: number
 }
 

diff --git a/src/components/Hook/useReadTimer.ts b/src/components/Hook/useReadTimer.ts
@@ -5,11 +5,10 @@ import { useEffect, useRef } from 'react'
 import { analytics } from '~/common/utils'
 
 type Props = {
-  articleId: string
   container?: React.RefObject<HTMLDivElement>
 }
 
-export const useReadTimer = ({ articleId, container }: Props) => {
+export const useReadTimer = ({ container }: Props) => {
   const router = useRouter()
 
   //in ms
@@ -25,11 +24,14 @@ export const useReadTimer = ({ articleId, container }: Props) => {
     }, 3000)
 
     const storeReadTime = () => {
-      if (articleId && readTimer)
+      if (router?.query?.shortHash && readTimer) {
+        const value = router.query.shortHash
+        const shortHash = value instanceof Array ? value[0] : value || ''
         analytics.trackEvent('read_time', {
-          articleId,
+          shortHash,
           time: readTimer.current,
         })
+      }
     }
 
     window.addEventListener('scroll', handleScroll)

diff --git a/src/views/ArticleDetail/Content/index.tsx b/src/views/ArticleDetail/Content/index.tsx
@@ -119,7 +119,7 @@ const Content = ({
     }
   }, [lastScroll])
 
-  useReadTimer({ articleId, container: contentContainer })
+  useReadTimer({ container: contentContainer })
 
   return (
     <>