Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom RCON Broadcast Source Code #9

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

thejcpalma
Copy link
Owner

Add Custom RCON Broadcast Source Code

Summary

This pull request adds the custom RCON broadcast source code to the project, following the feature introduced in PR #5. The changes encompass the inclusion of essential code, dependencies, and updates to the Dockerfile to facilitate the build and integration of the custom RCON broadcast binary.

Motivation and Context

The addition of the custom RCON broadcast feature, as outlined in PR #5, is needed for the capability to broadcast messages with spaces (not supported natively as spaces break the message).

After a lot of tries and using either underscores _ or dashes - to concatenate the messages, I thought that it just isn't readable or pleasant at all.

I did some research with 'invisible' spaces (other characters that would replace the spaces but would be invisible) and ended up encountering this information about ASCII Code for NBSP and a proof of concept by @Darkhand81 via this Reddit post so I decided to code it a robust solution in Go so it could be compiled and used inside the container like @gorcon's rcon-cli.

Description

The primary changes include:

  • Introduction of the custom RCON broadcast source code to the project.
  • Inclusion of necessary dependencies.
  • Updates to the Dockerfile to ensure the build process incorporates the custom RCON broadcast binary.

Testing Instructions

To validate these changes:

  1. Build the project and ensure the custom RCON broadcast binary is successfully compiled.
  2. Run the server with the new image.
  3. Verify that the RCON broadcast command now supports spaces.

Checklist

  • I have performed a self-review of my own code
  • I have updated the documentation (if necessary)
  • My changes do not introduce any breaking changes or bugs

@thejcpalma thejcpalma merged commit de777d1 into main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant