10_1038_s41586_018_0654_5 #189
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
||
|
|
||
| def load(data_dir, sample_fn, **kwargs): | ||
| fn = os.path.join(data_dir, sample_fn) |
There was a problem hiding this comment.
It looks like you are not using fn, so you can just take this line out!
| import numpy as np | ||
|
|
||
|
|
||
| def load(data_dir, sample_fn, **kwargs): |
There was a problem hiding this comment.
If you only have a single file, it is not necessary to use sample_fn and you can use def load(data_dir, **kwargs): instead here
| @@ -0,0 +1,44 @@ | |||
| dataset_structure: | |||
| dataset_index: 1 | |||
| sample_fns: | |||
There was a problem hiding this comment.
You can leave this field empty if you only have a single file name here to reduce complexity!
| observation_wise: | ||
| cellontology_original_obs_key: "cell_cluster" | ||
| feature_wise: | ||
| var_ensembl_col: |
There was a problem hiding this comment.
You will need to supply one of these to give some sort of gene name list.
le-ander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.