Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/handle solve args #748

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Refactor/handle solve args #748

wants to merge 26 commits into from

Commits on Sep 22, 2024

  1. move the alpha check to GWSolver level instead of parent classes

    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    310b273 View commit details
    Browse the repository at this point in the history

  2. add tests to check if alpha fails or not

    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    6c8d42d View commit details
    Browse the repository at this point in the history

  3. remove kwargs on a more public problem class

    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    0b06cc4 View commit details
    Browse the repository at this point in the history

  4. pre-commit

    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    feca7ec View commit details
    Browse the repository at this point in the history

  5. add test that asserts type error when unrecognized args are given

    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    c7cceb1 View commit details
    Browse the repository at this point in the history

  6. set default according to the data provided

    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    9edaafb View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    376eccf View commit details
    Browse the repository at this point in the history

  8. Revert "remove kwargs on a more public problem class" 

    This reverts commit 0b06cc4.
    @selmanozleyen
    selmanozleyen committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    01c89a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. improve the tests to also use other rank solvers

    @selmanozleyen
    selmanozleyen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    49c8bbc View commit details
    Browse the repository at this point in the history

  2. remove skipped tests and add link to other skipped test

    @selmanozleyen
    selmanozleyen committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f303a14 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge branch 'main' into refactor/handle-solve-args

    @selmanozleyen
    selmanozleyen authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9457676 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. adapt to was solvers new api

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1582baa View commit details
    Browse the repository at this point in the history

  2. update the tests

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a21c45f View commit details
    Browse the repository at this point in the history

  3. update tests for solvers new api

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    a1dfd64 View commit details
    Browse the repository at this point in the history

  4. adapt tests for solvers new api

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    e4dea94 View commit details
    Browse the repository at this point in the history

  5. check if it's callable for solvers initializer instance instead of st… 

    …ring
    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    608ca73 View commit details
    Browse the repository at this point in the history

  6. again simply linear_ot_solver -> linear_solver

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ae2c681 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    895085d View commit details
    Browse the repository at this point in the history

  8. fix test for also fgw tests

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7e472dc View commit details
    Browse the repository at this point in the history

  9. lint

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    19d7f35 View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9e069bf View commit details
    Browse the repository at this point in the history

  11. fix linting errors

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    23c7caa View commit details
    Browse the repository at this point in the history

  12. fix test_backend tests. There were some ignored args

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    aeb1621 View commit details
    Browse the repository at this point in the history

  13. format

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6543d57 View commit details
    Browse the repository at this point in the history

  14. update test_pass_arguments

    @selmanozleyen
    selmanozleyen committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    0b517a6 View commit details
    Browse the repository at this point in the history

  15. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9cb9c36 View commit details
    Browse the repository at this point in the history