Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps/update ott #557

Merged
merged 8 commits into from
Aug 7, 2023
Merged

Deps/update ott #557

merged 8 commits into from
Aug 7, 2023

Conversation

MUCDK
Copy link
Collaborator

@MUCDK MUCDK commented Jun 21, 2023

No description provided.

@giovp
Copy link
Member

giovp commented Jun 29, 2023

I think this can be closed for now?

@MUCDK MUCDK requested review from michalk8 and giovp August 6, 2023 08:06
Copy link
Collaborator

@michalk8 michalk8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor comments.

src/moscot/backends/ott/solver.py Outdated Show resolved Hide resolved
tests/problems/space/test_mixins.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #557 (3ef7fe7) into main (1b03127) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   77.40%   77.46%   +0.06%     
==========================================
  Files          36       36              
  Lines        3589     3590       +1     
  Branches      633      633              
==========================================
+ Hits         2778     2781       +3     
+ Misses        543      542       -1     
+ Partials      268      267       -1     
Files Changed Coverage Δ
src/moscot/backends/ott/solver.py 92.64% <ø> (+1.47%) ⬆️
src/moscot/problems/cross_modality/_translation.py 96.15% <ø> (ø)
src/moscot/problems/generic/_generic.py 96.00% <ø> (ø)
src/moscot/problems/space/_alignment.py 100.00% <ø> (ø)
src/moscot/problems/space/_mapping.py 100.00% <ø> (ø)
src/moscot/problems/time/_lineage.py 95.83% <ø> (ø)
src/moscot/backends/ott/_utils.py 62.79% <100.00%> (ø)
...moscot/problems/spatiotemporal/_spatio_temporal.py 100.00% <100.00%> (ø)

@MUCDK MUCDK merged commit 4ffcf14 into main Aug 7, 2023
6 checks passed
@MUCDK MUCDK deleted the deps/update_ott branch August 7, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants