Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TensorFlow 2 model fitting for negative binomial noise #88

Open
wants to merge 142 commits into
base: development
Choose a base branch
from

Conversation

picciama
Copy link
Collaborator

Adds tensorflow 2 specific code at batchglm/train/tf2/.
Includes negative binomial noise model.
No changes in other folders were made.
To import, we will need to apply changes to api/models/glm_nb.py, so that it can import from batchglm/train/tf2/ instead of batchglm/train/tf/

@davidsebfischer davidsebfischer changed the title Eager executing TensorFlow 2 training with negative binomial noise TensorFlow 2 model fitting for negative binomial noise Oct 23, 2019
@picciama
Copy link
Collaborator Author

picciama commented Nov 5, 2019

Branch tf2_compatibility merged into tf2. Tf2 can now be merged with dev.
tf2 api has been added on the tf2_compatibility branch before, but doesn't affect tf1.

@picciama picciama self-assigned this Nov 5, 2019
@davidsebfischer
Copy link
Contributor

Checking locally:

git diff --name-status tf2..tf2_compatibility
D batchglm/train/tf2/init.py
D batchglm/train/tf2/base/init.py
D batchglm/train/tf2/base/estimator.py
D batchglm/train/tf2/base/external.py
D batchglm/train/tf2/base/model.py
D batchglm/train/tf2/base/optim.py
D batchglm/train/tf2/base_glm/README.md
D batchglm/train/tf2/base_glm/init.py
D batchglm/train/tf2/base_glm/estimator.py
D batchglm/train/tf2/base_glm/external.py
D batchglm/train/tf2/base_glm/layers.py
D batchglm/train/tf2/base_glm/layers_gradients.py
D batchglm/train/tf2/base_glm/model.py
D batchglm/train/tf2/base_glm/optim.py
D batchglm/train/tf2/base_glm/processModel.py
D batchglm/train/tf2/base_glm/training_strategies.py
D batchglm/train/tf2/base_glm/vars.py
D batchglm/train/tf2/glm_beta/init.py
D batchglm/train/tf2/glm_beta/estimator.py
D batchglm/train/tf2/glm_beta/external.py
D batchglm/train/tf2/glm_beta/layers.py
D batchglm/train/tf2/glm_beta/layers_gradients.py
D batchglm/train/tf2/glm_beta/model.py
D batchglm/train/tf2/glm_beta/processModel.py
D batchglm/train/tf2/glm_beta/vars.py
D batchglm/train/tf2/glm_nb/init.py
D batchglm/train/tf2/glm_nb/estimator.py
D batchglm/train/tf2/glm_nb/external.py
D batchglm/train/tf2/glm_nb/layers.py
D batchglm/train/tf2/glm_nb/layers_gradients.py
D batchglm/train/tf2/glm_nb/model.py
D batchglm/train/tf2/glm_nb/processModel.py
D batchglm/train/tf2/glm_nb/vars.py

All changes are in tf2, that looks fine.

@davidsebfischer
Copy link
Contributor

waiting for #92

@picciama
Copy link
Collaborator Author

refactoring finished. The arguments for the training_method are not identical to the ones in train/tf1 which allows to access the method from within diffxpy.

@ilan-gold ilan-gold mentioned this pull request Jan 27, 2022
@picciama picciama changed the base branch from dev to development September 23, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants