Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38045 - Fix differing hidden_value variable name #744

Merged
merged 1 commit into from
Dec 16, 2024
+3 −1
Merged

Fixes #38045 - Fix differing hidden_value variable name #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/views/api/v2/ansible_variables/show.json.rabl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ object @ansible_variable

attribute :parameter
attributes :id, :variable, :ansible_role, :ansible_role_id, :description, :override,
:variable_type, :hidden_value?, :validator_type,
:variable_type, :validator_type,
:validator_rule, :merge_overrides, :merge_default,
:avoid_duplicates, :override_value_order, :created_at, :updated_at,
:default_value, :imported
Expand All @@ -19,3 +19,5 @@ end
node :override_values_count do |lk|
lk.lookup_values.count
end

node :hidden_value, &:hidden_value?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned here, the hidden_value does not appear to be used in this query. Could you clarify how this change impacts the functionality? I might be missing the reason why it’s necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking into this further, I noticed that this change only affects the API call and does not impact the GraphQL query.

Loading