Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose /metrics/ #597

Closed

Conversation

cemeng
Copy link

@cemeng cemeng commented Apr 28, 2022

This commit includes prometheus client for node.js (prom-client) and
adds /metrics/ endpoint that a Prometheus server can scrape.

This would address #551

Few notes:

  • Trailing slash is needed somehow, /metrics will lead to 404. I am not that familiar with express, if anyone can help that'd be great, ideally we want both /metrics and /metrics/ to show metrics.
  • The default metrics exposed might not be enough to be useful, for example: it doesn't have http request time etc - these need to be added as custom metrics.

This commit includes prometheus client for node.js (prom-client) and
adds /metrics/ endpoint that a Prometheus server can scrape.
@poeti8 poeti8 closed this Nov 25, 2022
@Tchoupinax Tchoupinax mentioned this pull request Jun 28, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants