Gate PRs on build success #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristanlabelle
commented
Nov 13, 2024
.github/workflows/build-and-test.yml
Outdated
| @@ -59,3 +59,13 @@ jobs: | |||
| - name: CMake Build | |||
| shell: pwsh | |||
| run: cmake --build .\build | |||
|
|
|||
| go-no-go: # Required status check | |||
There was a problem hiding this comment.
Self-blocking to remember adding the required check after merging
jeffdav
approved these changes
Nov 13, 2024
jeffdav
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just merged this PR before the workflows completed, and realized that this repo doesn't have required checks. Since required checks are matched by name and difficult to version with GitHub Actions, this adds a single last job that will be the only required check and can have a stable name over time.