Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for elements requests. #114

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Add support for elements requests. #114

merged 3 commits into from
Oct 21, 2023

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Oct 20, 2023

Implement session/:sessionId/elements and session/:sessionId/element/:elementId/elements.

Copy link

@darinf darinf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so clear to me how all of these attributes connect to the WinUI objects we author. What is className? What is name? What is the difference between identifier and accessibilityId? I realize these have meaning in HTML and webdriver is based on that, but what do or should they mean for us? I guess with XPath we can somehow query for elements that are children of a particular element?

@jeffdav
Copy link
Contributor Author

jeffdav commented Oct 21, 2023

I hear you. Let's do a call and I can explain each one.

@jeffdav jeffdav merged commit 16a99a8 into main Oct 21, 2023
1 check passed
@jeffdav jeffdav deleted the jeff/elements branch October 21, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants