Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'or' resolver #47

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

klymenko-serhii
Copy link

if wrapped component thrown an error, this error should be returned
cover local error case with unit test

ref: #46

if wrapped component thrown an error, this error should be returned
cover local error case with unit test
@newsiberian
Copy link

@thebigredgeek , hi, could you, please, review this PR? my tests broken because of this, can't do deploy things

@newsiberian
Copy link

newsiberian commented Mar 8, 2019

Looking deeper at this change, I understand that it is invalid. It broke logic to other cases rather than "true, false, throw". It returns validation resolvers result instead of main resolver result. Check tests.

.then(res => resolve(res))
createResolver(conditions[i])(root, args, context, info)
.then(() => {
createResolver(resolver)(root, args, context, info)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return createResolver(resolver)(root, args, context, info)

@thebigredgeek
Copy link
Owner

Would love to either get this merged or close it out @klymenko-serhii . Can we get tests passed?

@thebigredgeek thebigredgeek merged commit d4a28ba into thebigredgeek:master Mar 4, 2020
@thebigredgeek
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants