[WIP]:Initial Compose functionality and tests

[mringer]

#4

Quick and dirty implementation of the compose functionality proposed in the API v2 thread.
With some basic tests.

Proposed Usage:

// This works.
const base = new Composable( resolve => {}, error => {} );
const composed = base.compose( { 
  r1: { resolve: r => {}, error: e =>  }, 
  r2: { resolve: r => {}, error: e =>  },
  r3: resolve => {}
});

// probably need to bump up the ES version to make this work.
const gqlResolvers = { Mutaitons: { ...composed } };

[thebigredgeek]

Couldn't we just add a compose helper similar to and and or? By that, I mean rather than constructing a Composable couldn't we pass a series of resolvers into a compose HoF?

const isHappy = compose(
  isNotSad,
  isNotMad,
  isNotStressed,
  isNotAnxious
)(
(root, args, context, info) => ...
(root, args, context, error, info) => ...
)

[mringer]

Yeah, absolutely. Figured I'd stick strictly to the proposed implementation in the v2 spec, but that's totally reasonable.

[thebigredgeek]

Oh I see what you did. This is actually quite clever! Let's stick with this approach, but maybe axe the "composable" class requirement?

[mringer]

Yeah, we can make composable a function, rather than a class. It's more consistent with the rest of the API.

[mringer]

@thebigredgeek ok, refactored and added a few more tests.

// The basic API would be: 
const myResolver = createResolver( resolve => {}, error => {} );
const base = composable( resolve => {}, error => {} );

// All composed will pass calls and bubble errors though base.
const composed = base.compose( { 
  r1: { resolve: r => {}, error: e => {}  },  // declate separate resolve and error handlers
  r3: resolve => {}, // resolve declared inline 
  r4: myResolver // reuse a pre-constructed resolver
});

// And provide your Query and Mutation wiring like so...

{ Query: {
  someResolver: resFn,
  ...composed
},
Mutation: {
  someMutation: muteFn,
  ...composed
}

Added babel-plugin-transform-object-rest-spread for the spread operator syntax.

Updated babel-preset-es2015 to babel-preset-env as recommended by babel's docs. (though not strictly necessary for this PR)

[thebigredgeek]

Right, sorry... what I meant was that couldn't we just do something like...

const base = createResolver(
   () => undefined,
   err => err
);

// All composed will pass calls and bubble errors though base.
const composed = base.compose( { 
  r1: { resolve: r => {}, error: e => {}  },  // declate separate resolve and error handlers
  r3: resolve => {}, // resolve declared inline 
  r4: myResolver // reuse a pre-constructed resolver
});

// And provide your Query and Mutation wiring like so...

{ Query: {
  someResolver: resFn,
  ...composed
},
Mutation: {
  someMutation: muteFn,
  ...composed
}

So basically just adding base.compose in addition to base.createResolver? Thoughts?

[thebigredgeek]

@mringer bump

[mringer]

Word, busy couple weeks at work, should be able to circle back to this in the next couple days.

[mringer]

@thebigredgeek I think this is what you were asking for.

[thebigredgeek]

glorious