Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 9229: Babel v4-via-v6 #986

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jech
Copy link
Contributor

@jech jech commented Mar 31, 2022

This adds support for displaying routes announced according to RFC 9229 .

@jech jech changed the title Babel v4viav6 RFC 9229: Babel v4viav6 May 31, 2022
@jech jech changed the title RFC 9229: Babel v4viav6 RFC 9229: Babel v4-via-v6 May 31, 2022
@jech
Copy link
Contributor Author

jech commented Jan 7, 2023

@mcr, @fenner Could you please take a look? This is being deployed in production.

Copy link
Member

@mcr mcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thank for the additional test case.
Do you have coverage of all the code paths?

@jech
Copy link
Contributor Author

jech commented Jan 7, 2023

No, the provided trace only contains Update TLVs with the new encoding. The new encoding is also allowed in Request TLVs, but they are NOT RECOMMENDED by the RFC, and are not generted by any implementation in existence: I'd need to specifically craft a packet with them.

@jech
Copy link
Contributor Author

jech commented Mar 18, 2023

Ping?

@mcr mcr requested a review from guyharris March 19, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants