Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pflog: the default rulenr is "-1" #1089

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pflog: the default rulenr is "-1" #1089

wants to merge 2 commits into from

Commits on Oct 9, 2023

  1. pflog: the default rulenr is "-1" 

    As reported by an OPNsense user doing a security scan pf/pflog can
drop e.g. invalid length packets under the default rule which also
uses a -1 value like subrulenr.

Transform the displayed value from "4294967295" to "-1" in this case
because it is more correct (although both are suboptimal for processing).

FreeBSD: https://cgit.freebsd.org/src/tree/sys/netpfil/pf/pf_ioctl.c?id=3347078000c078f2e67214ef1ba2e0bffe1aea4f#n349
OpenBSD: https://github.com/openbsd/src/blob/142580dd4dc788acb41545aca79c845e04d1cb7d/sys/net/pf_ioctl.c#L242

See also: opnsense/core#6800
    @fichtner
    fichtner committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bb6ddad View commit details
    Browse the repository at this point in the history

  2. pflog: use the OpenBSD way of printing this edge case

    @fichtner
    fichtner authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0403ad2 View commit details
    Browse the repository at this point in the history