Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLM Assisted Tagging #1540

Merged
merged 3 commits into from
Dec 10, 2024
Merged

LLM Assisted Tagging #1540

merged 3 commits into from
Dec 10, 2024

Conversation

sudan45
Copy link
Contributor

@sudan45 sudan45 commented Nov 27, 2024 •
edited
Loading

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 marked this pull request as draft November 27, 2024 09:41
@sudan45 sudan45 changed the title LLM Assisted Tagging WIP: LLM Assisted Tagging Nov 27, 2024
@sudan45 sudan45 force-pushed the feature/assisted-tagging-with-llm branch 3 times, most recently from d47a31f to 5c3f54d Compare December 4, 2024 08:51
@AdityaKhatri AdityaKhatri force-pushed the feature/assisted-tagging-with-llm branch from 5c3f54d to 968a83b Compare December 4, 2024 10:35
@sudan45 sudan45 changed the title WIP: LLM Assisted Tagging WIP LLM Assisted Tagging Dec 5, 2024
@sudan45 sudan45 force-pushed the feature/assisted-tagging-with-llm branch from 968a83b to 5cc2e15 Compare December 5, 2024 06:17
@Rup-Narayan-Rajbanshi
Copy link
Contributor

Lets add dependent PR link in this PR. I think this PR has dependency with #1541 (review). @sudan45 .

Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi requested changes Dec 5, 2024
View reviewed changes
apps/assisted_tagging/schema.py Outdated Show resolved Hide resolved
apps/project/serializers.py Outdated Show resolved Hide resolved
@sudan45 sudan45 force-pushed the feature/assisted-tagging-with-llm branch from 533475d to aad7056 Compare December 5, 2024 09:21
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 105 lines in your changes missing coverage. Please review.

Project coverage is 79.42%. Comparing base (2d6961d) to head (6b89470).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
apps/deepl_integration/handlers.py 22.33% 80 Missing ⚠️
apps/geo/mutations.py 0.00% 7 Missing ⚠️
apps/deepl_integration/serializers.py 66.66% 6 Missing ⚠️
apps/assisted_tagging/dataloaders.py 55.55% 4 Missing ⚠️
apps/lead/filter_set.py 25.00% 3 Missing ⚠️
apps/assisted_tagging/tasks.py 0.00% 2 Missing ⚠️
apps/assisted_tagging/models.py 87.50% 1 Missing ⚠️
apps/assisted_tagging/schema.py 92.30% 1 Missing ⚠️
apps/assisted_tagging/serializers.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1540      +/-   ##
===========================================
- Coverage    79.75%   79.42%   -0.34%     
===========================================
  Files          464      464              
  Lines        30146    30402     +256     
  Branches      3386     3420      +34     
===========================================
+ Hits         24043    24146     +103     
- Misses        6103     6256     +153

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sudan45 sudan45 changed the title WIP LLM Assisted Tagging LLM Assisted Tagging Dec 5, 2024
@sudan45 sudan45 marked this pull request as ready for review December 5, 2024 10:37
@sudan45 @AdityaKhatri
Integrate llm assisted endpoint
7f9579b 
Update llm assisted tagging query

Add dataloader of llm assisted tagging

Integrate llm auto classification

Cleanup unwanted code
@AdityaKhatri AdityaKhatri force-pushed the feature/assisted-tagging-with-llm branch from 85575df to b14a3e2 Compare December 5, 2024 11:46
@sudan45 sudan45 force-pushed the feature/assisted-tagging-with-llm branch 4 times, most recently from 6b89470 to 8eee12b Compare December 9, 2024 04:36
@sudan45 sudan45 force-pushed the feature/assisted-tagging-with-llm branch from 8eee12b to a785f3a Compare December 9, 2024 09:33
@AdityaKhatri AdityaKhatri self-assigned this Dec 10, 2024
thenav56
thenav56 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good other then the geo

susilnem
susilnem approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM!

susilnem

This comment was marked as spam.

Sign in to view

@AdityaKhatri AdityaKhatri merged commit 130c5a0 into develop Dec 10, 2024
6 of 9 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/assisted-tagging-with-llm branch December 10, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@thenav56 thenav56 thenav56 approved these changes

Assignees

@AdityaKhatri AdityaKhatri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sudan45 @Rup-Narayan-Rajbanshi @thenav56 @susilnem @AdityaKhatri