Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag in analysis_framework #1381

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add tag in analysis_framework #1381

merged 2 commits into from
Nov 28, 2023

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Nov 9, 2023

Addresses

Changes

  • Add AF Tags

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@thenav56 thenav56 force-pushed the feature/af-tags branch 2 times, most recently from db6e09c to 8df667f Compare November 10, 2023 07:56
@AdityaKhatri AdityaKhatri mentioned this pull request Nov 24, 2023
Merged
11 tasks
@AdityaKhatri AdityaKhatri marked this pull request as ready for review November 28, 2023 04:06
@AdityaKhatri AdityaKhatri requested a review from sudan45 November 28, 2023 04:07
sudan45
sudan45 previously approved these changes Nov 28, 2023
View reviewed changes
@AdityaKhatri AdityaKhatri changed the base branch from develop to project/auto-extraction November 28, 2023 04:35
@AdityaKhatri AdityaKhatri dismissed sudan45’s stale review November 28, 2023 04:35

The base branch was changed.

Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rup-Narayan-Rajbanshi
Rup-Narayan-Rajbanshi reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thenav56 Dai. lets check for failed test case.

@AdityaKhatri AdityaKhatri merged commit 18414fe into project/auto-extraction Nov 28, 2023
6 of 7 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/af-tags branch November 28, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@sudan45 sudan45 sudan45 approved these changes

Assignees

@sudan45 sudan45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thenav56 @Rup-Narayan-Rajbanshi @sudan45 @AdityaKhatri