Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add props for disabling image zoom on scroll #172

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add props for disabling image zoom on scroll #172

merged 2 commits into from
Jul 9, 2024

Conversation

subinasr
Copy link
Contributor

@subinasr subinasr commented Jul 1, 2024 •
edited by tnagorra
Loading

This PR ensures that there are

  • No unnecessary console logs
  • No unwanted comments
  • No typos
  • yarn typecheck shows no issue
  • yarn lint shows no issue

This PR adds one or more new components / utils

  • Add the newly created component and its props to exports
  • Write story for newly created component(s)
  • No empty files

This PR fixes or updates existing components / utils

  • Update / add story to reflect the changes
  • Doesn't introduce breaking changes

Beta release vXX.XX.XX-beta.YY

  • Add a commit for beta release

@subinasr subinasr requested a review from tnagorra July 1, 2024 09:19
@tnagorra tnagorra force-pushed the fix/disable-scroll-zoom branch from b7d23d6 to ae61451 Compare July 5, 2024 05:55
@AdityaKhatri AdityaKhatri merged commit 9480169 into develop Jul 9, 2024
5 of 6 checks passed
@AdityaKhatri AdityaKhatri deleted the fix/disable-scroll-zoom branch July 9, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnagorra tnagorra Awaiting requested review from tnagorra

Assignees

@tnagorra tnagorra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@subinasr @tnagorra @AdityaKhatri