Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating stylelint to latest #1056

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

araujoarthur0
Copy link
Collaborator

Helps #1037

Stylelint will stop working with new electron dependencies (not sure why)
I'm taking the chance to update it and stylelint-config-standard dependencies.
In this new version, running "npm run lint-fix:css" brought a lot of changes to style.css

I also had to remove one of our rules from .stylelintrc.json as it was deprecated in v15
https://github.com/stylelint/stylelint/blob/382961fb6eb67557910a1ff7430a7a180f888bcc/docs/migration-guide/to-15.md?plain=1#L77

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1227117) 80.00% compared to head (faccc35) 80.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1056   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files          20       20           
  Lines        1270     1270           
  Branches      191      191           
=======================================
  Hits         1016     1016           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite all the changes in the css, it seems that the app looks and feels the same way

@tupaschoal tupaschoal merged commit 8f2ae80 into thamara:main Jan 28, 2024
9 checks passed
@araujoarthur0 araujoarthur0 deleted the update-stylelint branch January 29, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants