Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not store secrets in configmaps #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vixns
Copy link
Contributor

@vixns vixns commented Sep 27, 2024

No description provided.

@th0th
Copy link
Owner

th0th commented Oct 14, 2024

Thanks for the PR 💐

Even tough I agree with the idea of "not storing sensitive information in the configmap", it doesn't feel right to move all configuration to a secret. If there is a way to separate configuration options like hosts, ports etc from sensitive information, we can go that way maybe?

@vixns
Copy link
Contributor Author

vixns commented Oct 14, 2024

"One or more TOML files can be read by passing --config config.toml multiple times. " ( source: https://listmonk.app/docs/configuration/ )
Splitting the configuration between a CM and a secret seems doable, it depends how toml files are merged. Another way would be to use environment variables for non sensitive content instead of a configmap.

@th0th
Copy link
Owner

th0th commented Oct 14, 2024

"One or more TOML files can be read by passing --config config.toml multiple times. " ( source: https://listmonk.app/docs/configuration/ ) Splitting the configuration between a CM and a secret seems doable, it depends how toml files are merged. Another way would be to use environment variables for non sensitive content instead of a configmap.

Do you know if there is any configuration that is doable by the config file, but not the environment variables? If everything is configurable by environment variables, we can go that way, and move sensitive information to a secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants