Fix redos #94
Open
Fix redos #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex used to evaluate URLs is vulnerable to catastrophic backtracking to the '\w+:?\w*@' construction. Replace the URL regex with a slightly more complex test: 1. First apply a length limit 2. Then apply the vulnerable regex
|
Suggest we update Travis to use node v6 or v8, but I can replace 'let/const' with 'var'. Let me know. |
|
Done. If you merge this, seems like a good time to cut a new major version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the REDOS security vulnerability I disclosed by email.