Update dependencies for non-beta graphene-django v3 release #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`graphene-django` released a non-beta version of v3 in Sept 2022 (https://github.com/graphql-python/graphene-django/releases/tag/v3.0.0).
|
With the latest commit to bump to the newly-released graphene-django 3.0.2 https://github.com/graphql-python/graphene-django/releases/tag/v3.0.2 (which includes this graphql-python/graphene-django#1401), the performance-related tests are now passing. The only test that still fails is the unrelated one mentioned here #83 (comment), for which that PR has added a workaround. |
sjdemartini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphene-djangoreleased a non-beta version of v3 in Sept 2022 (https://github.com/graphql-python/graphene-django/releases/tag/v3.0.0).This updates the dev dependencies accordingly, to no longer point to the beta releases.
This PR is meant as demonstration only, since in its current form,Now resolved with graphene-django 3.0.2.graphene-django-optimizerunfortunately actually does not properly SQL-optimize nested fields (among other things), when used with the latest version ofgraphene-django. This can be seen in that several tests related to SQL optimization now fail after this version upgrade, such astest_should_select_nested_prefetch_and_select_related_fields.