Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-12050 | fix: warn instead of error rosa_creatorn_arn update validation #831

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Oct 24, 2024

OCM-12050
This validation enforces only the initial user that created the cluster can update the cluster resources, this is not ideal considering customers can use other users to update it.
For now it will be considered a warning instead and will be evaluated in a new form to be re introduced

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Copy link

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gdbranco. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gdbranco gdbranco changed the title OCM-12050 | fix: remove rosa_creatorn_arn update validation OCM-12050 | fix: warn instead of error rosa_creatorn_arn update validation Oct 24, 2024
Copy link

openshift-ci bot commented Oct 24, 2024

@gdbranco: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rosa-sts-private-critical-high-presubmit c704611 link true /test rosa-sts-private-critical-high-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gdbranco
Copy link
Contributor Author

Test failed deleting vpc dependencies only, moving ahead

@gdbranco gdbranco merged commit 3865ff9 into terraform-redhat:main Oct 24, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant