Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-11805 | ci: Review version and version pattern usage #820

Conversation

radtriste
Copy link
Contributor

What this PR does / why we need it:
Simplify the way we set version/channel group in the automation code and let the CI override the configuration when needed

Which issue(s) this PR fixes
https://issues.redhat.com/browse/OCM-11805

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Copy link

openshift-ci bot commented Oct 14, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@radtriste radtriste force-pushed the ocm-11805-refactor-version-profile branch 2 times, most recently from d6fc444 to ce45ed4 Compare October 14, 2024 12:30
@radtriste radtriste marked this pull request as ready for review October 14, 2024 12:31
@openshift-ci openshift-ci bot requested review from jameszwang and oriAdler October 14, 2024 12:31
@radtriste
Copy link
Contributor Author

/test ?

Copy link

openshift-ci bot commented Oct 14, 2024

@radtriste: The following commands are available to trigger required jobs:

  • /test images
  • /test rosa-hcp-advanced-critical-high-presubmit
  • /test rosa-hcp-private-critical-high-presubmit
  • /test rosa-sts-advanced-critical-high-presubmit
  • /test rosa-sts-private-critical-high-presubmit
  • /test unit

The following commands are available to trigger optional jobs:

  • /test rosa-classic-full-resources-optional-presubmit
  • /test rosa-day1-supplemental-optional-presubmit
  • /test rosa-hcp-advanced-optional-presubmit
  • /test rosa-hcp-arm-critical-high-presubmit
  • /test rosa-hcp-arm-optional-presubmit
  • /test rosa-hcp-encryption-optional-presubmit
  • /test rosa-hcp-full-resources-optional-presubmit
  • /test rosa-hcp-network-optional-presubmit
  • /test rosa-hcp-private-optional-presubmit
  • /test rosa-hcp-upgrade-y-optional-presubmit
  • /test rosa-hcp-upgrade-z-optional-presubmit
  • /test rosa-sts-advanced-day1-negative-optional-presubmit
  • /test rosa-sts-advanced-optional-presubmit
  • /test rosa-sts-private-day1-negative-optional-presubmit
  • /test rosa-sts-private-optional-presubmit
  • /test rosa-sts-shared-vpc-optional-presubmit
  • /test rosa-sts-upgrade-y-optional-presubmit
  • /test rosa-sts-upgrade-z-optional-presubmit

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-terraform-redhat-terraform-provider-rhcs-main-images
  • pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-hcp-advanced-critical-high-presubmit
  • pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-hcp-private-critical-high-presubmit
  • pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-sts-advanced-critical-high-presubmit
  • pull-ci-terraform-redhat-terraform-provider-rhcs-main-rosa-sts-private-critical-high-presubmit
  • pull-ci-terraform-redhat-terraform-provider-rhcs-main-unit

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@radtriste
Copy link
Contributor Author

/test rosa-sts-shared-vpc-optional-presubmit

@radtriste radtriste force-pushed the ocm-11805-refactor-version-profile branch from ce45ed4 to 0dd3e6a Compare October 15, 2024 07:05
@radtriste
Copy link
Contributor Author

/test rosa-sts-shared-vpc-optional-presubmit

@radtriste
Copy link
Contributor Author

teardown issue on ci/prow/rosa-sts-private-critical-high-presubmit. This is a known issue from Hive, not related to this PR

@radtriste
Copy link
Contributor Author

/override ci/prow/rosa-sts-private-critical-high-presubmit

Copy link

openshift-ci bot commented Oct 15, 2024

@radtriste: Overrode contexts on behalf of radtriste: ci/prow/rosa-sts-private-critical-high-presubmit

In response to this:

/override ci/prow/rosa-sts-private-critical-high-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xueli181114
Copy link
Contributor

/lgtm

@xueli181114
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xueli181114

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cdbfff6 into terraform-redhat:main Oct 15, 2024
13 checks passed
@radtriste radtriste deleted the ocm-11805-refactor-version-profile branch October 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants