Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-11521 | fix: validate custom machinepool disk size #817

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

willkutler
Copy link
Contributor

@willkutler willkutler commented Oct 11, 2024

What this PR does / why we need it:
Adds validation for custom disk size for both day 1 & 2 classic and HCP machine pools created with TF. Previously these fields were not validated in the provider, so failures would only happen on the API side.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):
Fixes #OCM-11521

Change type

  • New feature
  • [x ] Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • [x ] Subsystem tests

Checklist

  • [ x] Subject and description added to both, commit and PR.
  • [ x] Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from ciaranRoche and vkareh October 11, 2024 20:01
Copy link

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign osherdp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 11, 2024

Hi @willkutler. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@willkutler willkutler force-pushed the OCM-11521 branch 2 times, most recently from b76237e to fb9d40d Compare October 14, 2024 16:01
@willkutler willkutler force-pushed the OCM-11521 branch 2 times, most recently from 1439310 to f0b8616 Compare October 14, 2024 17:44
@marcolan018
Copy link
Contributor

lgtm

@willkutler
Copy link
Contributor Author

/ok-to-test

Copy link

openshift-ci bot commented Oct 15, 2024

@willkutler: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@robpblake
Copy link
Contributor

/ok-to-test

@willkutler
Copy link
Contributor Author

/retest

6 similar comments
@gdbranco
Copy link
Contributor

/retest

@gdbranco
Copy link
Contributor

/retest

@gdbranco
Copy link
Contributor

/retest

@gdbranco
Copy link
Contributor

/retest

@gdbranco
Copy link
Contributor

/retest

@gdbranco
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Oct 26, 2024

@willkutler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rosa-hcp-advanced-critical-high-presubmit ca26262 link true /test rosa-hcp-advanced-critical-high-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gdbranco
Copy link
Contributor

Failure unrelated to the validation added, cluster provision is being slow. Merging

@gdbranco gdbranco merged commit ac13962 into terraform-redhat:main Oct 26, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants