OCM-6285 | feat: Day1 SG support for HCP #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterkepley
force-pushed
the
ocm-6285
branch
2 times, most recently
from
fbb91dd to
6052d7d
Compare
|
/retest |
|
/test rosa-sts-advanced-critical-high-presubmit |
hunterkepley
force-pushed
the
ocm-6285
branch
from
6052d7d to
6e65eca
Compare
|
/test rosa-sts-private-critical-high-presubmit |
2 similar comments
|
/test rosa-sts-private-critical-high-presubmit |
|
/test rosa-sts-private-critical-high-presubmit |
gdbranco
reviewed
Oct 10, 2024
hunterkepley
force-pushed
the
ocm-6285
branch
from
6e65eca to
c3d8c49
Compare
|
/test rosa-sts-private-critical-high-presubmit |
|
/retest-required |
gdbranco
reviewed
Oct 14, 2024
hunterkepley
force-pushed
the
ocm-6285
branch
2 times, most recently
from
8a558e6 to
ee77625
Compare
|
/lgtm |
|
/retest-required |
hunterkepley
force-pushed
the
ocm-6285
branch
from
ee77625 to
73ff861
Compare
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gdbranco, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6b69a69
into
terraform-redhat:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows HCP clusters to have additional compute SGs on creation, following the introduced support for day 1 HCP SGs in CS/ROSA
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):Fixes #OCM-6285
Change type
Checklist
https://issues.redhat.com/browse/OCM-6285