Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use less privilege roles for ci service account #459

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Dec 30, 2024

No description provided.

@q2w q2w force-pushed the roles_downgrade branch 2 times, most recently from f13edd3 to 257657b Compare December 30, 2024 16:00
@q2w q2w changed the title chore: Roles downgrade fix: use less privilege roles for ci service account Dec 30, 2024
@q2w q2w marked this pull request as ready for review December 30, 2024 16:04
@q2w q2w requested review from erlanderlo and a team as code owners December 30, 2024 16:04
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest marking this a chore if immediate release is not needed.

@q2w
Copy link
Collaborator Author

q2w commented Jan 2, 2025

Suggest marking this a chore if immediate release is not needed.

We would need to create a release with this change and other planned changes! Will not merge the release PR immediately and wait for other PRs to get merged!

@q2w q2w merged commit ff60365 into terraform-google-modules:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants