Feature/7 re use new scheduled function #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for local_file creations
…waits for local_file creations
|
We could possibly add some better tests to verify the functions work as intended. But after applying locally I have verified both the scheduled and event driven functions are being triggered. And I do see data showing up in bigquery for the slo-pipeline |
ocervell
suggested changes
Dec 18, 2019
There was a problem hiding this comment.
LGTM, need one change once terraform-google-scheduled-function PR is merged. For the tests, we can add them in a further PR. Good work !
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on
terraform-google-modules/terraform-google-event-function#38
and
terraform-google-modules/terraform-google-scheduled-function#28
Being merged and released first. Then we can update module source codes to move off of my forks.Updates the
slomodule to use thescheduled-functionmodule now that it has proper support for waiting forlocal_filecreations before creating the archive for the cloud functionUpdates
slo-pipelineto useevent-functionmodule instead of duplicated functionality. Also relies on newlocal_filetoarchivedependency functionalityUpdates the setup and tests to pass