Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable docker-compose-js and types unit tests #3893

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Re-enable docker-compose-js and types unit tests #3893

merged 3 commits into from
Jan 8, 2025

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jan 7, 2025

This PR makes the following changes:

  • bump docker-compose-js from v1.4.2 to v1.4.3
  • re-enable unit tests for docker-compose-js and types packages
  • update docker-compose-js tests to account for changes to package since the tests were disabled

@busma13 busma13 force-pushed the reenable-docker-compose-js-tests branch from 1fe9c19 to f80174d Compare January 8, 2025 14:49
@busma13 busma13 marked this pull request as ready for review January 8, 2025 15:18
@busma13 busma13 requested review from sotojn and godber January 8, 2025 15:22
jsnoble
jsnoble approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit 593aa70 into master Jan 8, 2025
47 checks passed
@jsnoble jsnoble deleted the reenable-docker-compose-js-tests branch January 8, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

@sotojn sotojn Awaiting requested review from sotojn

@godber godber Awaiting requested review from godber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@busma13 @jsnoble