Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Set Jest transformIgnorePatterns to default #3880

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Dec 16, 2024

This PR makes the following changes:

  • In jest.config.base.js explicitly set transformIgnorePatterns to the default (['/node_modules/', '\\.pnp\\.[^\\/]+$']), which will skip running transforms on node-modules or pnp files. We were overriding the default with an empty array. Standard practice is to only transform specific dependencies if there is a need.
  • Remove patch for unicorn-magic dependency, as it is no longer being broken by the jest transform.
  • Add README to ./patches explaining how to make a patch using patch-package. This also prevents the patches directory from being removed if there are no patches, breaking the docker build.

Ref: #3871, #3874

@busma13 busma13 requested review from godber and sotojn December 16, 2024 17:37
@busma13 busma13 marked this pull request as ready for review December 16, 2024 17:55
Copy link
Contributor

@sotojn sotojn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@godber godber merged commit d21aba3 into master Dec 16, 2024
46 checks passed
@godber godber deleted the jest-stop-default-transformIgmorePatterns-override branch December 16, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants