Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker ratelimit ci #3679

Merged
merged 40 commits into from
Jul 11, 2024
Merged

Docker ratelimit ci #3679

merged 40 commits into from
Jul 11, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jul 8, 2024

This PR makes the following changes:

  • Add images cmd to scripts
    • images list creates a list of images that CI will need
    • images save will use the list to pull and save those images
  • Update test.yml workflow to check for a docker image cache, create one if needed, then use the cache to load images on all jobs.
  • Update test-runner to load images from cache if in CI
  • Update scripts from 0.80.0 to 0.81.0

ref: #3676

@busma13 busma13 force-pushed the docker-ratelimit-ci branch from c01060c to e56de8f Compare July 10, 2024 21:30
@busma13 busma13 force-pushed the docker-ratelimit-ci branch from c541b43 to 81abb17 Compare July 11, 2024 17:49
@busma13 busma13 marked this pull request as ready for review July 11, 2024 22:05
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the one issue called out here actually works at the moment, we can fix that in the follow up clean up PR.

if (!fs.existsSync(filePath)) {
throw new Error(`No file found at ${filePath}. Have you restored the cache?`);
}
subprocess = await execa.command(`kind --name ${this.clusterName} load image-archive <(gunzip -c ${filePath})`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how the <(gunzip ..) subprocess would work without the shell=true option.

@godber godber merged commit 7b08514 into master Jul 11, 2024
63 checks passed
@godber godber deleted the docker-ratelimit-ci branch July 11, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants