-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker ratelimit ci #3679
Docker ratelimit ci #3679
Conversation
c01060c
to
e56de8f
Compare
Co-authored-by: Joseph Soto <[email protected]>
Co-authored-by: Joseph Soto <[email protected]>
c541b43
to
81abb17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the one issue called out here actually works at the moment, we can fix that in the follow up clean up PR.
if (!fs.existsSync(filePath)) { | ||
throw new Error(`No file found at ${filePath}. Have you restored the cache?`); | ||
} | ||
subprocess = await execa.command(`kind --name ${this.clusterName} load image-archive <(gunzip -c ${filePath})`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how the <(gunzip ..)
subprocess would work without the shell=true
option.
This PR makes the following changes:
images
cmd to scriptsimages list
creates a list of images that CI will needimages save
will use the list to pull and save those imagestest.yml
workflow to check for a docker image cache, create one if needed, then use the cache to load images on all jobs.test-runner
to load images from cache if in CIscripts
from 0.80.0 to 0.81.0ref: #3676