-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to docker image #3677
Conversation
When this PR is ready for review, lets:
|
d35e9b8
to
79e8f53
Compare
I will hold off on bumping versions until after a review, as I don't want to trigger another CI run currently. |
I've reviewed the labels and they look good for opencontainers image-spec |
@busma13 do you have an image built from this branch? Can you run the following command on the IMAGE and paste the output here?
|
|
So |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve this after you bump it to v2.1.0
Correct. I set a local env var - export GITHUB_SHA=someHashValue |
…HUB_SHA build args
bump: (minor) [email protected], [email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], @terascope/[email protected] bump: (minor) @terascope/[email protected], [email protected] bump: (minor) [email protected], [email protected] bump: (minor) [email protected], [email protected]
2691ac0
to
9f4f0f9
Compare
This PR makes the following changes:
dockerBuild
function to allow abuildArgs
array.publishToDocker
function to pass the followingbuildArgs
:TERASLICE_VERSION
: equal toversion
in the teraslice rootpackage.json
.BUILD_TIMESTAMP
: equal to the result ofnew Date().toISOString()
immediately before thedockerBuild
function is called (ex:2024-07-10T14:43:09.429Z
).GITHUB_SHA
: equal to the value ofprocess.env.GITHUB_SHA
immediately before thedockerBuild
function is called. In the Github Actions CI pipeline where this script runs it will equalthe commit SHA that triggered the workflow
(ex:ffac537e6cbbf934b08745a378932722df287a53
).ref: #3257