Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teraslice-cli - fix old asset build #3670

Merged
merged 2 commits into from
Jun 26, 2024
Merged

teraslice-cli - fix old asset build #3670

merged 2 commits into from
Jun 26, 2024

Conversation

godber
Copy link
Member

@godber godber commented Jun 26, 2024 •
edited
Loading

Removing the format: esm argument to esbuild lets old assets build correctly.

@godber godber requested a review from jsnoble June 26, 2024 20:42
jsnoble
jsnoble approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godber godber changed the title Fix old asset build teraslice-cli - fix old asset build Jun 26, 2024
@godber godber merged commit 34fe6a8 into master Jun 26, 2024
59 checks passed
@godber godber deleted the fix-old-asset-build branch June 26, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godber @jsnoble