Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test roll bug2 #3329

Closed
wants to merge 2 commits into from
Closed

Test roll bug2 #3329

wants to merge 2 commits into from

Conversation

godber
Copy link
Member

@godber godber commented Jan 4, 2023

This isn't meant to be merged, it's just here as a convenience for testing:

terascope/elasticsearch-assets#970

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #3329 (e974814) into master (2b9fc76) will decrease coverage by 26.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #3329       +/-   ##
===========================================
- Coverage   76.80%   50.50%   -26.31%     
===========================================
  Files         745      572      -173     
  Lines       23012    17495     -5517     
  Branches     4232     3162     -1070     
===========================================
- Hits        17675     8836     -8839     
- Misses       4842     8433     +3591     
+ Partials      495      226      -269     
Impacted Files Coverage Δ
...ponents/src/operations/shims/operation-api-shim.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/src/operations/shims/legacy-slice-events-shim.ts 5.55% <0.00%> (-94.45%) ⬇️
...ackages/teraslice-op-test-harness/lib/operation.js 4.91% <0.00%> (-91.81%) ⬇️
packages/job-components/src/operations/slicer.ts 9.52% <0.00%> (-85.72%) ⬇️
packages/data-mate/src/column/Column.ts 11.42% <0.00%> (-84.29%) ⬇️
...ackages/data-mate/src/data-frame/metadata-utils.ts 10.81% <0.00%> (-83.79%) ⬇️
packages/utils/src/big-map.ts 3.94% <0.00%> (-82.90%) ⬇️
...ponents/src/operations/shims/legacy-reader-shim.ts 14.70% <0.00%> (-82.36%) ⬇️
packages/data-mate/src/data-frame/DataFrame.ts 3.51% <0.00%> (-82.12%) ⬇️
packages/data-types/src/graphql-helper.ts 18.75% <0.00%> (-81.25%) ⬇️
... and 576 more

@godber
Copy link
Member Author

godber commented Sep 6, 2023

Actually, I think we should modify and merge this. However, lets not overwrite any of the existing files. Lets move all of these changes into a subdirectory like examples/multiple-es-clusters and adapt the files so they run in place there. It will be useful to have a more complex/realistic example laying around.

@godber
Copy link
Member Author

godber commented Oct 4, 2023

I think we've got all of the good stuff out of this PR, I'm going to close it.

@godber godber closed this Oct 4, 2023
@godber godber deleted the testRollBug2 branch November 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants