Merge pull request #697 from terascope/change-default-spaces-api-retries

v2.5.2 - Change default retries to 3 in spaces_reader
terascope · Apr 14, 2021 · 8846d92 · 8846d92
2 parents 59b376d + 7ee341d
commit 8846d92
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 9 deletions.
diff --git a/asset/asset.json b/asset/asset.json
@@ -1,4 +1,4 @@
 {
     "name": "elasticsearch",
-    "version": "2.5.1"
+    "version": "2.5.2"
 }
diff --git a/asset/package.json b/asset/package.json
@@ -1,6 +1,6 @@
 {
     "name": "asset",
-    "version": "2.5.1",
+    "version": "2.5.2",
     "private": true,
     "workspaces": {
         "nohoist": [
@@ -18,7 +18,7 @@
     "dependencies": {
         "@terascope/data-mate": "^0.27.1",
         "@terascope/elasticsearch-api": "^2.19.0",
-        "@terascope/elasticsearch-asset-apis": "^0.4.1",
+        "@terascope/elasticsearch-asset-apis": "^0.4.2",
         "@terascope/job-components": "^0.50.0",
         "@terascope/teraslice-state-storage": "^0.26.0",
         "@terascope/utils": "^0.37.0",

diff --git a/asset/src/spaces_reader_api/schema.ts b/asset/src/spaces_reader_api/schema.ts
@@ -40,7 +40,7 @@ const apiSchema = {
     },
     retry: {
         doc: 'The number of times that the spaces client will try to retry a request',
-        default: 0,
+        default: 3,
         format: Number
     }
 };

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
     "name": "elasticsearch-assets",
     "description": "bundle of processors for teraslice",
-    "version": "2.5.1",
+    "version": "2.5.2",
     "private": true,
     "workspaces": [
         "packages/*",

diff --git a/packages/elasticsearch-asset-apis/package.json b/packages/elasticsearch-asset-apis/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@terascope/elasticsearch-asset-apis",
-    "version": "0.4.1",
+    "version": "0.4.2",
     "description": "Elasticsearch reader and sender apis",
     "publishConfig": {
         "access": "public"

diff --git a/packages/elasticsearch-asset-apis/src/spaces-api/spaces-client.ts b/packages/elasticsearch-asset-apis/src/spaces-api/spaces-client.ts
@@ -26,7 +26,7 @@ export default class SpacesReaderClient implements ReaderClient {
         this.config = config;
         this.logger = logger;
         this.uri = `${config.endpoint}/${config.index}`;
-        this.retry = config.retry ?? 0;
+        this.retry = config.retry ?? 3;
     }
 
     getRequestOptions(

diff --git a/test/spaces_reader/fetcher-spec.ts b/test/spaces_reader/fetcher-spec.ts
@@ -169,7 +169,8 @@ describe('spaces_reader fetcher', () => {
                 endpoint: baseUri,
                 interval: '30s',
                 delay: '30s',
-                timeout: 50
+                timeout: 50,
+                retry: 0,
             }, _opConfig, { size: maxSize });
 
             const harness = new WorkerTestHarness(newTestJobConfig({
@@ -235,7 +236,8 @@ describe('spaces_reader fetcher', () => {
                         interval: '30s',
                         delay: '30s',
                         date_field_name: 'date',
-                        timeout: 75
+                        timeout: 75,
+                        retry: 0
                     },
                     {
                         _op: 'noop'