Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling and log spams in Executor #1145

Merged

Conversation

eabatalov
Copy link
Contributor

@eabatalov eabatalov commented Jan 2, 2025

  • Generate "customer error" if failed to deserialize graph or function in Initialize RPC.
    ** These errors are not logged as they are in customer owned code.
    ** These errors are added to function's stderr so customer can see them.
  • Fix the test for missing module. It didn't check anything because g.run never raises if function fails.
  • Use short formatting for exceptions in prod (non-dev) mode so only short backtraces are present in logs without fully rendered local vars in the backtraces and etc. This reduces log spam.
  • Revert previous quickfixes that suppress logging of exception details in Executor.

Testing:

make check
make test

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • [n/a] If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

* Generate "customer error" if failed to deserialize graph or
  function in Initialize RPC.
  ** These errors are not logged as they are in customer owned code.
  ** These errors are added to function's stderr so customer can
     see them.
* Fix the test for missing module. It check anything because g.run never
  raises.
* Use short formatting for exceptions in prod (non-dev) mode so only
  short backtraces are present in logs without fully rendered local vars
  in the backtraces and etc. This reduces log spam.
* Revert previous quickfixes that suppress logging of exception details
  in Executor.

Testing:

make check
make test
@eabatalov eabatalov force-pushed the eugene-rpc-server-initialize-error-handling-cleanup branch from c49e1b4 to 54d60b3 Compare January 2, 2025 16:42
@eabatalov eabatalov marked this pull request as ready for review January 2, 2025 17:00
@eabatalov eabatalov merged commit 7df0d05 into main Jan 2, 2025
8 checks passed
@eabatalov eabatalov deleted the eugene-rpc-server-initialize-error-handling-cleanup branch January 2, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant