Executor: force Function Executor RunTask concurrency=1 #1138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously before in-Process Function Executor was introduced max Function concurrency in Executor was 1. We bring the previous behavior here but enforce the concurrency of 1 per Function Executor (not for the whole Executor). It's better this way cause it's hard for customers to reason about implications of running multiple concurrent tasks per Function Executor.
Also added tests that verify task concurrency for the same and different functions.
We'll revise this concurrency policy in the future if we allow customers to configure their functions' concurrency explicitly via function attributes.
I also did a big refactoring which results in task policy implementation simplification. This is how the current task policies are implemented now:
There also many other refactorings in this PR that help to implement the upcoming features in Executor and simplify the code base.
Testing:
make check
make test
Contribution Checklist
make fmt
inpython-sdk/
.make fmt
inserver/
.