Terminate Indexify processes in the end of GH Action test runs #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eabatalov
force-pushed
the
eugene-kill-function-executor-processes
branch
5 times, most recently
from
3377b05 to
8bb545d
Compare
Currently we don't cleanely terminate Indexify Server and Executor in the end of test runs. This results in a misleading collection of many orphaned processes in the end of test runs. Do the clean termination to remove the misleading orphaned processes collection and to run the code in Executor that terminates Function Executors cleanely. This ensures better line coverage in our CI GH Actions testing.
eabatalov
force-pushed
the
eugene-kill-function-executor-processes
branch
from
8bb545d to
8644802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't cleanely terminate Indexify Server and Executor in the end of test runs. This results in a misleading collection of many orphaned processes in the end of test runs. Do the clean termination to remove the misleading orphaned processes collection and to run the code in Executor that terminates Function Executors cleanely. This ensures better line coverage in our CI GH Actions testing.
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.