Move everything related to fetching tasks from server into its own class #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eabatalov
commented
Dec 13, 2024
| while self._should_run: | ||
| try: | ||
| async for task in self._task_fetcher.run(): | ||
| self._task_store.add_tasks([task]) |
There was a problem hiding this comment.
Adding tasks one by one might look inefficient but I'm going to remove task_store in the upcoming PRs. Also I measured duration of make test command and it didn't change with this PR. So should be good.
This is the first PR where I simplify agent.py by splitting it into components with dedicated responsibilities and interfaces. There's going to be more. Testing: make check make test
eabatalov
force-pushed
the
eugene-task-fetcher
branch
from
9366c4e to
d7ae774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR where I simplify agent.py by splitting it into components with dedicated responsibilities and interfaces. There's going to be more.
Testing:
make check
make test
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.