chore(dead code): remove unused invocation_finished on scheduler TaskCreationResult #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriousben
force-pushed
the
seriousben/clean-task-creation-result
branch
from
dc80416 to
1dc1130
Compare
diptanu
reviewed
Dec 4, 2024
| namespace: &str, | ||
| compute_graph: &str, | ||
| invocation_id: &str, | ||
| invocation_finished: bool, |
There was a problem hiding this comment.
Why was this removed? There were cases an invocation was still running but we were not creating new tasks.
There was a problem hiding this comment.
Just a GitHub display issue. We still have that helper.
| @@ -30,7 +30,6 @@ pub async fn handle_invoke_compute_graph( | |||
| compute_graph: event.compute_graph.clone(), | |||
| new_reduction_tasks: vec![], | |||
| processed_reduction_tasks: vec![], | |||
| invocation_finished: false, | |||
There was a problem hiding this comment.
This should be invocation_finished: true no?
There was a problem hiding this comment.
That is what is going to happen, but that attribute was not read anywhere.
In Create tasks, it checks for outstanding tasks to finalize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CreationResult has an invocation_finished attribute that is misleading since it is not used even though we have lots of logic around it in the scheduler.
What
Delete the attribute and simplify code setting it.
Testing
Contribution Checklist
make fmtinpython-sdk/.make fmtinserver/.