Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(feat): Download output of a function from the UI #1055

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

Default2882
Copy link
Contributor

Context

A small feature to download the execution output of a function within an invocation. If the encoder is json a file with .json extension will download, and if the encoder is cloudpickle a file with .bin extension will download. Addresses #1054.

Testing

Download button -

Screenshot 2024-11-21 at 8 29 28 PM

Clicking on the download button -

Screenshot 2024-11-21 at 8 30 15 PM

Viewing the .json file.

Screenshot 2024-11-21 at 8 30 38 PM

Contribution Checklist

  • [N/A] If the python-sdk was changed, please run make fmt in python-sdk/.
  • [N/A] If the server was changed, please run make fmt in server/.
  • [] Make sure all PR Checks are passing.

@Default2882
Copy link
Contributor Author

@adithyaakrishna @diptanu Created a small PR for UI to view output of a function, please take a look!

@adithyaakrishna
Copy link
Contributor

@Default2882 I added a few comments, otherwise it LGTM :)

Co-authored-by: Adithya Krishna  <[email protected]>
@Default2882
Copy link
Contributor Author

@adithyaakrishna Done, merged your changes!

@diptanu diptanu merged commit 4cab1d0 into tensorlakeai:main Dec 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants