Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Sequence Examples #6003

Closed

Conversation

AlexanderLavelle
Copy link
Contributor

This is a draft / suggestion based on 5689

Everything now goes to Sequence Examples. There is an isinstance filter to navigate the types.

This supports long-term development by natively implementing sequence type features, which TFX would need to lean on in order to support LLM training and so on.

@lego0901

@gbaned gbaned self-assigned this Jul 7, 2023
@gbaned gbaned requested a review from lego0901 July 7, 2023 15:08
@gbaned
Copy link
Contributor

gbaned commented Aug 2, 2023

Hi @lego0901 Can you please review this PR ? Thank you!

@lego0901
Copy link
Member

Hi @AlexanderLavelle, thanks a lot for your efforts on this.

We had a look at your PR and discussed internally. Unfortunately, we decided to politely reject your PR.

The main reason was "the backward compatibility". As a proto message type, SequenceExample is not compatible with the Example. What it means is that every code that uses tf.train.Example, regardless of if it is internal or external-Google, should change their way of packing the messages. We assumed that will bring a big burden to our existing customers to upgrade the TFX version.

I always appreciate your concern to our product. Sorry for my response. Thank you.

@lego0901 lego0901 closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants