Fixes missing kfp_pod_name execution property in Kubeflow Pipelines. (#…

…4157) * Fixes missing kfp_pod_name execution property in Kubeflow Pipelines. Kubeflow Dag Runner should record additional execution property to store pod names. See also kubeflow/pipelines#6138. PiperOrigin-RevId: 391220221 Co-authored-by: jiyongjung <[email protected]>
tensorflow · Aug 17, 2021 · 90ea51a · 90ea51a
1 parent 2f54c36
commit 90ea51a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -22,6 +22,8 @@
 
 ## Bug Fixes and Other Changes
 
+*   Fixed ths issue that kfp_pod_name is not generated as an execution property
+    for Kubeflow Pipelines.
 *   Fixed issue when InputValuePlaceholder is used as component parameter in
     container based component.
 *   Depends on `kubernetes>=10.0.1,<13`

diff --git a/tfx/orchestration/kubeflow/container_entrypoint.py b/tfx/orchestration/kubeflow/container_entrypoint.py
@@ -416,6 +416,7 @@ def main():
   # `args.runtime_parameter` should become List[str] by using "append".
   parser.add_argument('--runtime_parameter', type=str, action='append')
 
+  # TODO(b/196892362): Replace hooking with a more straightforward mechanism.
   launcher._register_execution = _register_execution  # pylint: disable=protected-access
 
   args = parser.parse_args()

diff --git a/tfx/orchestration/portable/launcher.py b/tfx/orchestration/portable/launcher.py
@@ -232,12 +232,8 @@ def _register_or_reuse_execution(
             '%s. Output artifacts may be overwritten.',
             execution.last_known_state)
       return execution
-    return execution_publish_utils.register_execution(
-        metadata_handler=metadata_handler,
-        execution_type=execution_type,
-        contexts=contexts,
-        input_artifacts=input_artifacts,
-        exec_properties=exec_properties)
+    return _register_execution(metadata_handler, execution_type, contexts,
+                               input_artifacts, exec_properties)
 
   def _prepare_execution(self) -> _ExecutionPreparationResult:
     """Prepares inputs, outputs and execution properties for actual execution."""