This repository has been archived by the owner on Apr 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 656
Add testing for notebooks [WIP] #99
Draft
kmader
wants to merge
9
commits into
tensorflow:master
Choose a base branch
from
kmader:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding code to execute the notebooks with nbconvert and ensure there are no error messages (as mentioned in PR tensorflow#97)
tweaking nbconvert code
tweaking nbconvert code
adding jupyter client
show kernels and override default kernel name
adding ipykernel and self-installer
tweaking ipython kernel line
setting kernel_name to default
changing to use testkernel
The biggest open issues now are
|
Oh, thanks, I’ll take a look! That being said, even just running the code would provide a layer of stability that lets us know when we break things. Thanks already for getting started; I may need some days to respond! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to implement some basic testing for the notebooks in response to the comment here: #97 (comment)