Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

Azure support #269

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Azure support #269

wants to merge 2 commits into from

Conversation

gabgoh
Copy link
Contributor

@gabgoh gabgoh commented Nov 19, 2020

Added azure support into lucid.misc.io

csvoss
csvoss approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@csvoss csvoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for grabbing this!

lucid/misc/io/__init__.py Outdated Show resolved Hide resolved
lucid/misc/io/reading.py Outdated Show resolved Hide resolved
lucid/misc/io/saving.py Outdated Show resolved Hide resolved
@ludwigschubert ludwigschubert self-assigned this Mar 12, 2021
@ludwigschubert
Copy link
Contributor

I'm happy to take this on, @gabgoh . Can you please check if you forgot to add lucid.misc.io.util (likely "./lucid/misc/io/util.py`) to this PR? Once you're touching it; could you add a tiny test file on an azure bucket and leave the URL here? (Or write the test directly, if you're inspired.)

@ludwigschubert ludwigschubert marked this pull request as draft March 12, 2021 15:32
@ludwigschubert ludwigschubert added awaiting reply Waiting for third-party reply lucid.misc labels Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@colah colah colah left review comments

@csvoss csvoss csvoss approved these changes

Assignees

@ludwigschubert ludwigschubert

Labels
awaiting reply Waiting for third-party reply lucid.misc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabgoh @ludwigschubert @colah @csvoss