-
Notifications
You must be signed in to change notification settings - Fork 656
WIP: bugfixes and enhancements to objectives #137
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will leave this to Ludwig to LGTM, but this looks nice! Welcome to Lucid, Gabe!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome first contribution! Let's chat details at 3!
Gabe, please rebase on master@HEAD—I've fixed an unrelated issue with Python 2 compatibility that didn't even let you run the (now still failing) tests in the Python 2 env. |
@googlebot I signed it! |
CLAs look good, thanks! |
1ca9496
to
852b1e9
Compare
05107e1
to
97c15a7
Compare
@gabgoh I'd still happily merge this, but I need a little bit of help. Can you rebase on tensorflow/lucid HEAD? Or transfer the branch from your fork to this repository so I can do so myself? |
New formatting for objectives
Access to tensors in after objectives is available now
TODO: Realize is a potentially breaking change to the lower levels of the lucid API. Make sure Ludwig is ok with the changes and all unit tests pass.