-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize testing for gcs
filesystem
#1400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vnvo2409 In our SIG IO meeting, the plan was that:
There are some ordering dependencies as we will need to wait for TF 2.5 final out first, then we will have |
@yongtang When I first wrote the
Afterwards, I discovered that As you said in #1229 (comment), we will eventually need some extra ops but I don't see any progress related to it. I would like to ask about the plan for incorporating |
I think the
gcs
filesystem plugins is now usable, the errors are fixed in #1396. I am inclined to refactor thegcs
filesystem to have it worked with #1229 (mostly adding some classes for inheritance), but it seems useless since we can not do adynamic_cast<RetryingGcsFileSystem*>
anyway. I would like to ask what we will do withgcs
filesystem plugin in the future ? @mihaimaruseac @yongtang