fix(console): handle nested style tags

[innocenzi]

This pull request is a follow-up of #703. It improves support for nested <style> tags and better handles ending tags (</style>).

 

Nesting <style>

The first change is the support for nested <style> tags. I changed the regular expression to use a negative lookahead ((?!\<style)) that prevents matching nested <style> tags. Without this, the following would be matched as one block:

<style="dim">[<style="fg-cyan">cyan</style>]</style>

The replacement would then miss styles. Now, it properly matches two distinct blocks.

 

Handling resets

The second change is an update to how </style> resets the current style. Instead of using 0m to reset all styles, it will use more specific reset codes depending on the opening tag.

For instance:

<style="dim"><style="fg-gray">dim-gray</style> just-dim</style>

Previously, after the first </style>, all colors and modifiers would be reset, so just-dim would use the default text style.

Now, </style> will reset the foreground color only, keeping the previous dim modifier intact, so just-dim will still be dimmed.

 

Note

This pull request depends on tempestphp/highlight#163 for the new reset cases on TerminalStyle.
Once tempest/highlight is tagged a new version, I'll update this PR with the new version and refactor the part of the code where I used strings instead of the missing TerminalStyle cases.

[brendt]

tempest/highlight is tagged :)

[coveralls]

Pull Request Test Coverage Report for Build 11834579899

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 68 of 68 (100.0%) changed or added relevant lines in 3 files are covered.
• 26 unchanged lines in 5 files lost coverage.
• Overall coverage increased (+0.05%) to 82.65%

---

Files with Coverage Reduction	New Missed Lines	%
src/Tempest/Console/src/Highlight/DynamicTokenType.php	1	91.8%
src/Tempest/Reflection/src/ClassReflector.php	2	95.92%
src/Tempest/Generation/src/ClassManipulator.php	3	81.25%
src/Tempest/Http/src/IsRequest.php	8	84.91%
src/Tempest/Core/src/PublishesFiles.php	12	83.33%

Totals
Change from base Build 11828633715:	0.05%
Covered Lines:	7617
Relevant Lines:	9216

---

💛 - Coveralls

[innocenzi]

Thanks—ready for review 👍

[brendt]

Merged!