Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GDScript support #52

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Add GDScript support #52

merged 3 commits into from
Mar 22, 2024

Conversation

assertchris
Copy link
Contributor

@assertchris assertchris commented Mar 21, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Mar 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8385459512

Details

  • 151 of 151 (100.0%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 94.689%
Totals Coverage Status
Change from base Build 8375181430: 0.8%
Covered Lines: 1034
Relevant Lines: 1092
💛 - Coveralls

@aidan-casey
Copy link
Member

@assertchris awesome! Thanks for the PR!

Do you mind running composer qa and re-pushing?

@brendt
Copy link
Member

brendt commented Mar 22, 2024

Chris, I love this! Such a perfect PR ❤️

@brendt brendt merged commit a95b69f into tempestphp:main Mar 22, 2024
4 checks passed
@assertchris assertchris deleted the feature/add-gdscript-support branch March 22, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@assertchris @coveralls @aidan-casey @brendt