registry: try to replace relative paths in README images #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
coredb-service-user
approved these changes
Oct 19, 2023
DarrenBaldwin07
approved these changes
Oct 19, 2023
|
|
||
| if let Ok((_, image)) = parse_markdown_image(remaining) { | ||
| // We're only interested in relative paths, so if we parsed a URL, skip it | ||
| if image.path_or_link.starts_with("http") { |
There was a problem hiding this comment.
Great job catching this case - lots of repos will have urls like this: https://github.com/DarrenBaldwin07/DarrenBaldwin07/assets/68653294/a53fce84-b120-489d-a795-12be94e67641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link for the testbed for this feature
Given a README that links to an image through a relative path to its repository, this PR introduces logic to fetch a URL for the same image that pgt.dev could use to render the image correctly
Example:
becomes